GitLab

Slavi wrote:

naming conventions:

• the variable for controlling the pantalaimon.username setting in the Draupnir role should not be called matrix_bot_draupnir_bot_username, but matrix_bot_draupnir_pantalaimon_username. It's the same for the password field. This will also make validation tasks (tasks/validate_config.yml) clearer. As it is now, I was wondering "Why are these variables only required when Pantalaimon is enabled?". With the correct naming, it's obvious they are part of the same pantalaimon section of the configuration
• homeserverUrl (in the Draupnir role) should ideally be controlled via a matrix_bot_draupnir_homeserver_url variable. Currently, the variable is called matrix_bot_draupnir_matrix_csapi_url.
• similarly, for rawHomeserverUrl (in the Draupnir role) we should have a new matrix_bot_draupnir_raw_homeserver_url variable. In defaults/main.yml, it can be defined in terms of matrix_homeserver_url
• matrix_bot_draupnir_use_pantalaimon should similarly be named matrix_bot_draupnir_pantalaimon_use